Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic updating fixes (README and Kured options) #1206

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

jr-dimedis
Copy link
Contributor

This PR contains a Kured configuration fix and README improvements and fixes regarding automatic and manual updating.

  • The sentinel path of Kured needs to be adjusted to point to the mountpoint in the container and not the original host path
  • Don't start transactional-update directly from the console, instead trigger the systemd service
  • Clarify control of automatic k3s updating

Fixes #1204.

- when performing transactional-update from CLI another
  configuration is used and afterwards the file
  /var/run/reboot-needed is created, instead of
  /var/run/reboot-required and Kured does not work
  as expected
- the upgrade has to be triggered using the systemd
  service instead
- it's important to switch off auto upgrading completely
  in the kube.tf and not just by removing the node labels
- otherwise the labels are created again on each agent
  restart or node reboot
- the previous wording implied that the labels are only
  an alternative to switching off, but they are actually
  an alternative to switching on.
- path has to point to the host's /var/run mountpoint
  in the container
Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks!

Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jr-dimedis, I will test this.

Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Will merge and release tomorrow 🙏

@mysticaltech mysticaltech merged commit b780aa3 into kube-hetzner:master Feb 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: kured wrong sentinel path
3 participants